Add Warning Messages for Adaptive QoS#8
Merged
ExtremeFiretop merged 3 commits intodevelopfrom Jun 8, 2025
Merged
Conversation
Add Warning Messages for Adaptive QoS If Adaptive QoS is not functional, display a warning message to the user in shell and the WebUI
Ignore annoying Shellcheck
Ignore Shellcheck x2
|
I’m not spending time approving PRs to the develop branch. Why does the develop branch exist? |
Member
Author
To each their own. The question has been answered multiple times though in the discussions. Develop is used as a middle point between production and the rest of the team. You already identified that the PR against master was not worth a new release. Well unless you want every teams members PR to be a new release. You need a place to commit those PRs too as a middle ground; called develop. Else the only choice is to commit against master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Warning Messages for Adaptive QoS
If Adaptive QoS is not functional, display a warning message to the user in shell and the WebUI